Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the deprecated codes #4679

Open
rleungx opened this issue Feb 25, 2022 · 3 comments
Open

Clean up the deprecated codes #4679

rleungx opened this issue Feb 25, 2022 · 3 comments
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@rleungx
Copy link
Member

rleungx commented Feb 25, 2022

Enhancement Task

We have many deprecated codes which have been kept for a long time. We can clean them up.
@rleungx rleungx added the type/enhancement The issue or PR belongs to an enhancement. label Feb 25, 2022
@rleungx rleungx mentioned this issue Feb 25, 2022
Merged
ti-chi-bot added a commit that referenced this issue Feb 25, 2022
@rleungx @ti-chi-bot
api: remove deprecated HTTP APIs (#4678)
fc1a932 
ref #4679

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
@mahjonp
Copy link

mahjonp commented Feb 26, 2022

Sadly said that tidb-operator has failed to deploy because of #4678. @rleungx

E0226 14:19:12.913749       1 pd_member_manager.go:188] failed to sync TidbCluster: [endless-oltp-tps-604649-1-698/tc]'s status, error: Error response 404 URL http://tc-pd.endless-oltp-tps-604649-1-698:2379/pd/health,body response: 404 page not found

@rleungx rleungx mentioned this issue Feb 27, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue Feb 27, 2022
@rleungx
api: add part of deprecated APIs back (#4680)
a4b1968 
ref #4679

Signed-off-by: Ryan Leung <[email protected]>
@overvenus
Copy link
Member

#4678 also breaks TiCDC integration tests.
See pingcap/tiflow@71be3b3

This was referenced Feb 28, 2022
Merged
Merged
@lhy1024
Copy link
Contributor

lhy1024 commented Nov 25, 2022

I think we can mark deprecated to enable-*-replica, which only is valid for replica-checker, since we use placement-rules as default in 5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@overvenus @mahjonp @lhy1024 @rleungx