Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imbalanced read results in instability of sysbench select_random_ranges/select_random_points performance (-25%~8%) #4529

Closed
Tracked by #5691
Yui-Song opened this issue Dec 31, 2021 · 9 comments
Assignees
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 affects-6.3 affects-6.4 found/automation severity/major type/bug The issue is confirmed as a bug.

Comments

@Yui-Song
Copy link

Bug Report

Imbalanced read results in instability of sysbench select_range_point performance (-25%~8%, compared with the baseline)

What did you do?

  1. Deploy a cluster
  2. Turn on prepare plan cache
  3. Run sysbench select_range_point

What did you expect to see?

The TPS of multiple tests are stable.

What did you see instead?

origin_img_v2_ccf16cb0-9285-4318-96de-49e648d5a2bg

TPS:37778
middle_img_v2_df923f3d-2744-485d-9067-88babb8154bg
middle_img_v2_8df9678b-bd03-4478-b6f7-1d3fcbbd066g

TPS:54453
middle_img_v2_19fcb3d1-ae09-4a3e-8faa-98f82e6bba6g

middle_img_v2_5e512be1-6cd5-409f-b25b-80d72710054g

What version of PD are you using (pd-server -V)?

commit ae23d40

@Yui-Song Yui-Song added the type/bug The issue is confirmed as a bug. label Dec 31, 2021
@Yui-Song
Copy link
Author

/severity critical

@Yui-Song
Copy link
Author

Yui-Song commented Dec 31, 2021

/found automation

@ti-chi-bot
Copy link
Member

@Yui-Song: The label(s) type/performance cannot be applied, because the repository doesn't have them.

In response to this:

/type performance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

1 similar comment
@ti-chi-bot
Copy link
Member

@Yui-Song: The label(s) type/performance cannot be applied, because the repository doesn't have them.

In response to this:

/type performance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@nolouch
Copy link
Contributor

nolouch commented Dec 31, 2021

We need some time to fix this issue.

@Yui-Song
Copy link
Author

Yui-Song commented Jan 4, 2022

/severity major

@Yui-Song
Copy link
Author

Yui-Song commented Jan 4, 2022

/remove-severity critical

@ti-chi-bot
Copy link
Member

@Yui-Song: These labels are not set on the issue: severity/critical.

In response to this:

/remove-severity critical

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@jebter jebter added the affects-5.4 This bug affects the 5.4.x(LTS) versions. label Jan 18, 2022
@VelocityLight VelocityLight added the affects-6.1 This bug affects the 6.1.x(LTS) versions. label May 20, 2022
@Yui-Song Yui-Song changed the title Imbalanced read results in instability of sysbench select_range_point performance (-25%~8%) Imbalanced read results in instability of sysbench select_random_ranges/select_random_points performance (-25%~8%) Aug 29, 2022
@lhy1024
Copy link
Contributor

lhy1024 commented Nov 9, 2022

After the optimization of the 6.3 and 6.4 versions, these two loads have been basically stable.

img_v2_54681919-32bc-4e8e-80e4-49c34068d5eg
In daily run, there will be no 25% drop.

image

In the comparison test, select_random_ranges (6tidb3tikv), 6.4 vs. 6.3 can increase by 19%, select_random_points (3tidb3tikv) is stable in 6.3, and the performance difference between 6.3 and 6.4 is not big.

However, it is worth noting that select_random_ranges is affected by the result of splitting region. If there are still regions that are difficult to schedule after the split, the hot-region-scheduler may still not find the optimal result, so theoretically there is room for further improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 affects-6.3 affects-6.4 found/automation severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

7 participants