address comment

Signed-off-by: Cabinfever_B <[email protected]>
tikv · Mar 24, 2023 · 279124d · 279124d
1 parent fd2641e
commit 279124d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/client/resource_group/controller/controller.go b/client/resource_group/controller/controller.go
@@ -861,7 +861,7 @@ func (gc *groupCostController) modifyTokenCounter(counter *tokenCounter, bucket
 		cfg.NewTokens = granted
 		cfg.NewRate = float64(bucket.GetSettings().FillRate)
 		counter.lastDeadline = time.Time{}
-		cfg.NotifyThreshold = math.Min((granted+counter.limiter.AvailableTokens(gc.run.now)), counter.avgRUPerSec*defaultTargetPeriod.Seconds()) * notifyFraction
+		cfg.NotifyThreshold = math.Min(granted+counter.limiter.AvailableTokens(gc.run.now), counter.avgRUPerSec*defaultTargetPeriod.Seconds()) * notifyFraction
 		if cfg.NewBurst < 0 {
 			cfg.NewTokens = float64(counter.getTokenBucketFunc().Settings.FillRate)
 		}

diff --git a/client/resource_group/controller/limiter.go b/client/resource_group/controller/limiter.go
@@ -300,6 +300,7 @@ func (lim *Limiter) Reconfigure(now time.Time,
 	defer lim.mu.Unlock()
 	log.Debug("[resource group controller] before reconfigure", zap.Float64("NewTokens", lim.tokens), zap.Float64("NewRate", float64(lim.limit)), zap.Float64("NotifyThreshold", args.NotifyThreshold), zap.Int64("burst", lim.burst))
 	if args.NewBurst < 0 {
+		lim.last = now
 		lim.tokens = args.NewTokens
 	} else {
 		now, _, tokens := lim.advance(now)