Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick TLS support to release-3.0, and set version to v3.0.11 #44

Merged
merged 2 commits into from
Mar 2, 2020

Conversation

kennytm
Copy link
Collaborator

@kennytm kennytm commented Feb 28, 2020

What have you changed? (mandatory)

  • Cherry-pick *: support TLS #40 (needed because TiDB Lightning uses the same binary for all 3.0+ channel).
  • Set version to 3.0.11 and update TiKV dependencies to 3.0.10.

What are the type of the changes? (mandatory)

  • Improvement (change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

Unit test.

Does this PR affect TiDB Lightning? (mandatory)

TiDB Lightning can use TLS in the 3.0 cluster.

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

* *: support TLS

Signed-off-by: kennytm <[email protected]>

* tests/integrations: make the entire test run on TLS connection

also added a test to ensure non-TLS-client <-> TLS-server fails.

Signed-off-by: kennytm <[email protected]>
@kennytm kennytm added status/PTAL This PR is ready for review. Add this label back after committing new changes release-blocker Must be merged before the next release labels Feb 28, 2020
@kennytm
Copy link
Collaborator Author

kennytm commented Feb 28, 2020

PTAL @WangXiangUSTC

@WangXiangUSTC
Copy link
Collaborator

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT1 One reviewer already commented LGTM (LGTM1) and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Mar 1, 2020
@kennytm kennytm merged commit 6020574 into release-3.0 Mar 2, 2020
@kennytm kennytm deleted the kennytm/cherry-pick-tls-to-3.0 branch March 2, 2020 07:34
@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) and removed status/LGT1 One reviewer already commented LGTM (LGTM1) labels Mar 2, 2020
kennytm added a commit to 3pointer/importer that referenced this pull request Apr 2, 2020
* *: support TLS (tikv#40)

* *: support TLS

Signed-off-by: kennytm <[email protected]>

* tests/integrations: make the entire test run on TLS connection

also added a test to ensure non-TLS-client <-> TLS-server fails.

Signed-off-by: kennytm <[email protected]>
3pointer added a commit that referenced this pull request Apr 2, 2020
* Cherry-pick TLS support to release-3.1 (#44)

* *: support TLS (#40)

* *: support TLS

Signed-off-by: kennytm <[email protected]>

* tests/integrations: make the entire test run on TLS connection

also added a test to ensure non-TLS-client <-> TLS-server fails.

Signed-off-by: kennytm <[email protected]>

* tests: fix build failure

Signed-off-by: kennytm <[email protected]>

Co-authored-by: kennytm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker Must be merged before the next release status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants