Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gRPC C core to v1.29.1 #466

Merged
merged 21 commits into from
Jun 11, 2020
Merged

Update gRPC C core to v1.29.1 #466

merged 21 commits into from
Jun 11, 2020

Conversation

hunterlxt
Copy link
Member

Signed-off-by: Xintao [email protected]

@hunterlxt
update grpc c core
ebf23d1 
Signed-off-by: Xintao <[email protected]>
@hunterlxt hunterlxt self-assigned this Jun 3, 2020
@hunterlxt
update travis
a5c9037 
Signed-off-by: Xintao <[email protected]>
hunterlxt added 2 commits June 5, 2020 01:04
@hunterlxt
remove use c++11
80e0b0f 
Signed-off-by: Xintao <[email protected]>
@hunterlxt
add comments for link
adadd47 
Signed-off-by: Xintao <[email protected]>
BusyJay
BusyJay reviewed Jun 5, 2020
View reviewed changes
grpc-sys/build.rs Outdated Show resolved Hide resolved
grpc-sys/build.rs Show resolved Hide resolved
tests-and-examples/certs/client1.crt Outdated Show resolved Hide resolved
hunterlxt added 2 commits June 5, 2020 17:53
@hunterlxt
remove setup
985a965 
Signed-off-by: Xintao <[email protected]>
@hunterlxt
adjust test sequence
a746265 
Signed-off-by: Xintao <[email protected]>
@hunterlxt hunterlxt mentioned this pull request Jun 7, 2020
Merged
@hunterlxt hunterlxt force-pushed the XT/update-core branch 2 times, most recently from 2e39ef1 to a746265 Compare June 8, 2020 05:30
@hunterlxt
find CoreFoundation
13672f1 
Signed-off-by: Xintao <[email protected]>
@hunterlxt
Copy link
Member Author

In addition to the openssl-src upgrade, I think the other parts are ready. PTAL @BusyJay

hunterlxt
hunterlxt commented Jun 9, 2020
View reviewed changes
grpc-sys/Cargo.toml Outdated Show resolved Hide resolved
@hunterlxt
Copy link
Member Author

BTW, I tested following #465 and found v1.29.1 still cannot be compiled with mingw environment. And the upstream does not seem to provide support for mingw.

BusyJay
BusyJay reviewed Jun 9, 2020
View reviewed changes
.github/workflows/ci.yml Show resolved Hide resolved
grpc-sys/Cargo.toml Outdated Show resolved Hide resolved
grpc-sys/Cargo.toml Outdated Show resolved Hide resolved
grpc-sys/build.rs Outdated Show resolved Hide resolved
tests-and-examples/certs/client1.crt Outdated Show resolved Hide resolved
hunterlxt added 3 commits June 9, 2020 19:31
@hunterlxt
address comments
ef3171f 
Signed-off-by: Xintao <[email protected]>
@hunterlxt
address comments
a6fde63 
Signed-off-by: Xintao <[email protected]>
@hunterlxt
address comments
ef4dcc6 
Signed-off-by: Xintao <[email protected]>
BusyJay
BusyJay reviewed Jun 10, 2020
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
grpc-sys/Cargo.toml Show resolved Hide resolved
tests-and-examples/tests/cases/auth_context.rs Outdated Show resolved Hide resolved
tests-and-examples/tests/cases/auth_context.rs Outdated Show resolved Hide resolved
@hunterlxt
address comments
b9639c8 
Signed-off-by: Xintao <[email protected]>
@hunterlxt
address comments
c307321 
Signed-off-by: Xintao <[email protected]>
yiwu-arbug
yiwu-arbug reviewed Jun 10, 2020
View reviewed changes
Copy link

@yiwu-arbug yiwu-arbug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick question: does openssl-vendered feature has effect if openssl feature is not used? Seems to me some code assume yes and some assume no.

@BusyJay
Copy link
Member

BusyJay commented Jun 11, 2020

@yiwu-arbug You can consider openssl-vendored as "openssl/vendored", so openssl feature is used. Unfortunately, '/' is not allowed in features name.

@hunterlxt hunterlxt added gRPC Core Related to grpc's c/cpp core and removed Work In Progress labels Jun 11, 2020
@hunterlxt hunterlxt merged commit 249e21b into tikv:master Jun 11, 2020
@hunterlxt hunterlxt deleted the XT/update-core branch June 11, 2020 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BusyJay BusyJay BusyJay approved these changes

@yiwu-arbug yiwu-arbug yiwu-arbug approved these changes

Assignees

@hunterlxt hunterlxt

Labels
gRPC Core Related to grpc's c/cpp core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hunterlxt @BusyJay @yiwu-arbug