sync etcd endpoints immediately after initializing the client #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vlad Dmitriev <[email protected]>
ti-chi-bot
bot
added
the
dco-signoff: yes
|
Welcome @vldmit! |
ti-chi-bot
bot
added
the
size/XS
zyguan
approved these changes
Feb 14, 2025
ti-chi-bot
bot
added
needs-1-more-lgtm
|
@cfzjywxk PTAL |
cfzjywxk
approved these changes
Feb 17, 2025
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, zyguan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1574
Problem Statement
etcd client would only run
SyncafterAutoSyncInterval(30 seconds), which makes tikv client vulnerable to the failure of endpoints provided inaddrsbefore the first sync happens. Specific failure scenario:--path=endpointendpointCheckVisibilityinKVStorestart to error outFix
We explicitly synchronize client endpoints with endpoints from etcd membership during client initialization phase. etcd client would continue to do periodic sync, we just force first sync to happen in the init phase.