Use cloud-hypervisor for net-vm on x86 #665
Open
+26
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slakkala
temporarily deployed
to
internal-build-workflow
GitHub Actions
Inactive
| hypervisor = { | ||
| # Use the same machine type as the host | ||
| x86_64-linux = "cloud-hypervisor"; | ||
| aarch64-linux = "qemu"; |
There was a problem hiding this comment.
why having a different vmm per architecture?
There was a problem hiding this comment.
The cloud-hypervisor PCI support on AArch64 is limited in functionality, and does not work with our wifi adaptor. Further, the PCI passing on AArch64 would only work in UEFI mode, which microvm does not support; and would probably be slower.
| shares = | ||
| [ | ||
| { | ||
| tag = "ro-store"; | ||
| source = "/nix/store"; | ||
| mountPoint = "/nix/.ro-store"; | ||
| proto = "virtiofs"; |
There was a problem hiding this comment.
can you check the extra time delay in booting and size that is incurred by using virtiofs?
There was a problem hiding this comment.
In my measurements the delay is negligible, less than 1s difference from boot to VM up.
The storage usage grows by 36 kB on AArch64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Replace QEMU with cloud-hypervisor for net-vm guest on x86 hardware.
cloud-hypervisor makes a differently connected virtual device, so the permanent name of the interface changes.
Move smcroute startup to NetworkManager dispatcher script to allow the guest to reach multi-user.target before host timeout reboots the VM.
Checklist for things done
x86_64aarch64riscv64nix flake check --accept-flake-configand it passesTesting
Verify that network connectivity works after configuring it.