-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security issue induced by German translation #223
Comments
I don't think it should be looking up different keys so I filed the issue above, but the values should not be different anyway, based on what devise provides. It looks like I made a mistake in 768785a#diff-eb19846118a4d36584de4bccd93b7a04 and this difference was propagated to some translations. |
JasonBarnabe
added a commit
that referenced
this issue
Feb 1, 2018
I have updated all strings to be the same for these two keys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A security issue has been induced by a German translation: https://www.localeapp.com/projects/377/translations/2034179?in_locale=1648
Source of the problem:
As those two translations are not exactly the same, it is possible to differentiate if, during login failure, an user exists in the database or not. This is actually a security treat, as if no locking mechanism has been setup, it is possible to check the existence of an user and then guess the password.
Translation updated in: https://www.localeapp.com/projects/377/translations/2034179?in_locale=1648
The text was updated successfully, but these errors were encountered: