fix: closer

tigrisdata · Sep 24, 2024 · a845e57 · a845e57
1 parent a5dde50
commit a845e57
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/provider/provider.go b/provider/provider.go
@@ -45,5 +45,5 @@ func (mp *MetricProvider) ServeHttp() {
 }
 
 func (mp *MetricProvider) Close() {
-	mp.reporter.Close()
+	mp.reporter.closer.Close()
 }
diff --git a/reporter/reporter.go b/reporter/reporter.go
@@ -63,7 +63,6 @@ func NewReporter() *Reporter {
 			promreporter.Options{Registerer: reg},
 		),
 	}
-	r.scopes = make(map[string]tally.Scope)
 
 	// Create root scope
 	scope, closer := tally.NewRootScope(tally.ScopeOptions{
@@ -72,9 +71,12 @@ func NewReporter() *Reporter {
 		Separator:              promreporter.DefaultSeparator,
 		OmitCardinalityMetrics: true,
 	}, 1*time.Second)
-	defer closer.Close()
+
+	// Add closer to reporter
+	r.closer = closer
 
 	// Add root scope to reporter
+	r.scopes = make(map[string]tally.Scope)
 	r.scopes["root"] = scope
 
 	// Add prometheus prefix for root scope