Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change junit inline namespace to normal namespace #1513

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/simple_junit/include/simple_junit/junit5.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ using string = std::string;

namespace common
{
inline namespace junit
namespace junit
{
struct Pass
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ class Interpreter : public rclcpp_lifecycle::LifecycleNode,

std::shared_ptr<rclcpp::TimerBase> timer;

common::JUnit5 results;
common::junit::JUnit5 results;

boost::variant<common::junit::Pass, common::junit::Failure, common::junit::Error> result;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@
class JunitXmlReporterTestCase
{
public:
explicit JunitXmlReporterTestCase(common::SimpleTestCase & testcase) : testcase_(testcase) {}
explicit JunitXmlReporterTestCase(common::junit::SimpleTestCase & testcase) : testcase_(testcase)
{
}

void reportCollision(const NPCDescription & npc, double time)
{
Expand All @@ -52,7 +54,7 @@ class JunitXmlReporterTestCase
testcase_.error.push_back(result);
}

common::SimpleTestCase & testcase_;
common::junit::SimpleTestCase & testcase_;
};

class JunitXmlReporter
Expand All @@ -77,7 +79,7 @@ class JunitXmlReporter
}

private:
common::JUnit5 results_;
common::junit::JUnit5 results_;
std::string output_directory_;
rclcpp::Logger logger_;
};
Expand Down
Loading