This repository was archived by the owner on May 18, 2024. It is now read-only.
Changes for return type ambiguity breaking modification to the compil… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er. A couple others for Stdin/Stdout also.
|
Thanks. This looks good. I'm going to wait a few days until I update my compiler and see what other pending breaking changes are planned so I can possibly do them all at once. |
|
Sounds good :) |
|
So the ContainerDecl syntax change has now been reverted as of ziglang/zig#1685. There are still a few things here which are good and need changing though so if you removed the ContainerDecl changes I'll happily merge. |
|
Should have fixed up everything else in d58a9d7. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…er. A couple others for Stdin/Stdout also. Not totally sure that I changed Metronome.zig correctly.