styling comprehensively with styler #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First styled with
strict = FALSEandscope = "tokens".Being more invasive than this configuration (e.g. with
strict = TRUE) did expose one issue withstyler@HEAD: lines breaks in function calls are not taking into account whether arguments are named or not (tidyverse/style#39).I attempted resolve that issue in r-lib/styler#318 and used this version to style with
scope = "tokens",strict = TRUE. Theenframe_data()call indata-raw/smiths.Rwas excluded from styling since it needed tribble-like alignment (r-lib/styler#317).