Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethink exporting dim_desc() #50

Closed
krlmlr opened this issue Mar 18, 2016 · 1 comment · Fixed by #55
Closed

Rethink exporting dim_desc() #50

krlmlr opened this issue Mar 18, 2016 · 1 comment · Fixed by #55
Milestone
1.0

Comments

@krlmlr
Copy link
Member

krlmlr commented Mar 18, 2016

Currently, it's exported because print.tbl_xxx() from dplyr and backends need to access it to print dimensions themselves. Perhaps printing dimensions, and the other information (source type, grouping, ...) should be responsibility of tibble, too.
@krlmlr krlmlr added this to the 1.0 milestone Mar 18, 2016
This was referenced Mar 21, 2016
Merged
Closed
krlmlr added a commit that referenced this issue Mar 21, 2016
@krlmlr
Merge pull request #55 from hadley/feature/50-remove-dim_desc
dcdd828 
- Don't export `dim_desc()` (#50, #55).
krlmlr pushed a commit that referenced this issue Mar 21, 2016
Merge tag 'v0.3-6'
731c5b3 
- `glimpse()` obtains default width from `tibble.width` option (#35, #56).
- Don't export `dim_desc()` (#50, #55).
- Don't test R-devel on AppVeyor because of missing directory on CRAN.
- Edits to `README` (#54, @jennybc).
krlmlr pushed a commit that referenced this issue Mar 21, 2016
Merge tag 'v0.4'
d91b064 
- Interface changes
    - `glimpse()` obtains default width from `tibble.width` option (#35, #56).
    - Don't export `dim_desc()` (#50, #55).
    - New `has_rownames()` and `remove_rownames()` (#44).
- Minor modifications
    - `frame_data()` returns 0-row but n-col data frame if no data.
    - `[[.tbl_df()` now falls back to regular subsetting when used with anything other than a single string (#29).
    - When used in list-columns, S4 objects only print the class name rather than the full class hierarchy (#33).
    - Add test that `[.tbl_df()` does not change class (#41, @jennybc).
    - Improve `[.tbl_df()` error message.
- Documentation
    - Improve documentation and vignette.
    - Update README, with edits (#52, @bhive01) and enhancements (#54, @jennybc).
- Code quality
    - Full test coverage (#24, #53).
    - Renamed `obj_type()` to `obj_sum()`, improvements, better integration with `type_sum()`.
    - Cleanup for `column_to_rownames()` and `rownames_to_columns()` (#45).
    - Cleanup for `repair_names()` (#43). Whitespace are not touched by this function (#47).
    - Cleanup for `add_row()` (#46).
    - Regression tests load known output from file (#49).
    - Internal cleanup.
    - Don't test R-devel on AppVeyor because of missing directory on CRAN.
@github-actions
Copy link
Contributor

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Don't export dim_desc() tidyverse/tibble
1 participant
@krlmlr