Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify leap_year() to support objects supported by year() #820

Merged
merged 3 commits into from
Nov 20, 2019
Merged

simplify leap_year() to support objects supported by year() #820

merged 3 commits into from
Nov 20, 2019

Conversation

earowang
Copy link
Contributor

closes #703

hadley
hadley approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a news bullet copying the existing style? (It's a bit different from the other tidyverse packages)

@earowang
Copy link
Contributor Author

earowang commented Nov 20, 2019 •
edited
Loading

Added a news bullet for leap_year().

@hadley hadley merged commit 6b3431a into tidyverse:master Nov 20, 2019
@hadley
Copy link
Member

hadley commented Nov 20, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley hadley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

leap_year() not working for a new class "yearmonth"
2 participants
@earowang @hadley