-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing the plot$labels
field
#6290
Comments
TODO: Send out PRs to packages |
A suggestion was raised in tidyverts/feasts#166 (comment). |
For the 32 affected packages, I have taken the following actions:
That being done, I think this issue should be considered resolved to the best of ggplot2s capabilities and the only thing left to do for me is to shepard the open PRs. |
This problem was identified in #6287 and affects 32 packages.
Many packages use the
labels
plot field in their tests to see if their code has correctly constructed their plot.We now only populate this field with the
labs()
function or when the plot is build, and no longer when layers are added automatically.We have an accessor in place that people can use (#6078).
Should we start sending out PRs to affected packages?
The text was updated successfully, but these errors were encountered: