Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing the plot$labels field #6290

Closed
teunbrand opened this issue Jan 22, 2025 · 3 comments
Closed

Testing the plot$labels field #6290

teunbrand opened this issue Jan 22, 2025 · 3 comments

Comments

@teunbrand
Copy link
Collaborator

This problem was identified in #6287 and affects 32 packages.

Many packages use the labels plot field in their tests to see if their code has correctly constructed their plot.
We now only populate this field with the labs() function or when the plot is build, and no longer when layers are added automatically.
We have an accessor in place that people can use (#6078).

Should we start sending out PRs to affected packages?

@teunbrand
Copy link
Collaborator Author

TODO: Send out PRs to packages

@teunbrand
Copy link
Collaborator Author

A suggestion was raised in tidyverts/feasts#166 (comment).
Essentially, annotate() populates labels and it would be nice if these were deprioritised in favour of regular layers.

@teunbrand
Copy link
Collaborator Author

For the 32 affected packages, I have taken the following actions:

  • I've sent out 28 PRs with suggested changes to tests.
  • I've sent out 3 emails to maintainers whose packages aren't on GitHub, warning them of this change.
  • I've filed 1 issue where a fix was not straightforward due to off-label use.

That being done, I think this issue should be considered resolved to the best of ggplot2s capabilities and the only thing left to do for me is to shepard the open PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant