Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Off-label use of plot labels #5

Open
teunbrand opened this issue Jan 31, 2025 · 0 comments
Open

Off-label use of plot labels #5

teunbrand opened this issue Jan 31, 2025 · 0 comments

Comments

@teunbrand
Copy link

Hi there,

The ggplot2 package is planning an update for around May 2025 and a reverse dependency test indentified a problem with the yamlet package.
The details are explained in tidyverse/ggplot2#6290, but essentially ggplot2 doesn't populate the plot$labels field before plot building anymore.

The change in ggplot2 is at odds with how labels are used in the .decorated_ggplot function. It appears to me that the plot labels are being used to iterate over aesthetics, but labels are not suitable to derive aesthetics. I think this is off-label use, and would suggest that the yamlet package changes its approach. You can test the changes yourself with the development version of ggplot2 (pak::pak("tidyverse/ggplot2"))

Best,
Teun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant