Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong documentation linked for scale_color_continuous with American spelling #3422

Closed
Ahobert opened this issue Jul 8, 2019 · 3 comments
Closed

Comments

@Ahobert
Copy link
Contributor

Ahobert commented Jul 8, 2019

Calling the documentation of scale_colour_continuous seems to work properly only with British spelling. Running ?scale_color_continuous calls the documentation of scale_colour_gradient instead.

related to issues #2851 and #3053

--

install.packages("ggplot2")
#> package 'ggplot2' successfully unpacked and MD5 sums checked
#> 
#> The downloaded binary packages are in

library(ggplot2)
?scale_colour_continuous
?scale_color_continuous

sessionInfo()
#> R version 3.6.0 (2019-04-26)
#> Platform: x86_64-w64-mingw32/x64 (64-bit)
#> Running under: Windows 10 x64 (build 14393)
#> 
#> Matrix products: default
#> 
#> locale:
#> [1] LC_COLLATE=German_Germany.1252  LC_CTYPE=German_Germany.1252   
#> [3] LC_MONETARY=German_Germany.1252 LC_NUMERIC=C                   
#> [5] LC_TIME=German_Germany.1252    
#> 
#> attached base packages:
#> [1] stats     graphics  grDevices utils     datasets  methods   base     
#> 
#> other attached packages:
#> [1] ggplot2_3.2.0
#> 
#> loaded via a namespace (and not attached):
#>  [1] Rcpp_1.0.1       knitr_1.22       magrittr_1.5     tidyselect_0.2.5
#>  [5] munsell_0.5.0    colorspace_1.4-1 R6_2.4.0         rlang_0.3.4     
#>  [9] stringr_1.4.0    highr_0.8        dplyr_0.8.0.1    tools_3.6.0     
#> [13] grid_3.6.0       gtable_0.3.0     xfun_0.6         withr_2.1.2     
#> [17] htmltools_0.3.6  assertthat_0.2.1 yaml_2.2.0       lazyeval_0.2.2  
#> [21] digest_0.6.18    tibble_2.1.1     crayon_1.3.4     purrr_0.3.2     
#> [25] glue_1.3.1       evaluate_0.13    rmarkdown_1.12   stringi_1.4.3   
#> [29] compiler_3.6.0   pillar_1.3.1     scales_1.0.0     pkgconfig_2.0.2

<sup>Created on 2019-07-08 by the [reprex package](https://reprex.tidyverse.org) (v0.2.1)</sup>
@paleolimbot
Copy link
Member

Good catch! I think this can be fixed by updating the @rdname tag here to scale_colour_continuous:

ggplot2/R/zxx.r

Lines 112 to 115 in a312cb4

#' @export
#' @rdname scale_gradient
#' @usage NULL
scale_color_continuous <- scale_colour_continuous

Ahobert added a commit to Ahobert/ggplot2 that referenced this issue Jul 8, 2019
karawoo pushed a commit that referenced this issue Jul 8, 2019
@karawoo
Copy link
Member

karawoo commented Jul 8, 2019

Closed in #3430, thanks!

@karawoo karawoo closed this as completed Jul 8, 2019
@lock
Copy link

lock bot commented Jan 4, 2020

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants