Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use null rather than na in exchange() #278

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Conversation

juliasilge
Copy link
Member

Closes #277

I feel like this is a fairly big change in the context of butcher, given that this low-level function is used everywhere.

@juliasilge
Copy link
Member Author

The error here on R-devel is due to r-lib/lobstr#48 and is the same problem we observe on main.

simonpcouch added a commit to tidymodels/extratests that referenced this pull request Jan 13, 2025
Copy link
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All for it!🪓 Thanks for pointing out the source of that unrelated GHA failure.

@juliasilge juliasilge merged commit 17b5d49 into main Jan 13, 2025
10 of 11 checks passed
@juliasilge juliasilge deleted the null-not-na-in-exchange branch January 13, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Butcher on a glm with a data.frame that has a single column
2 participants