ShellPkg: Add support to parse SPMI table in acpiview

[shkrc]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4818

Added support for acpiview shell utility to parse and print SPMI table

Cc: Abdul Lateef Attar [email protected]
Cc: Abner Chang [email protected]
Cc: Paul Grimes [email protected]
Cc: Zhichao Gao [email protected]
Signed-off-by: Shankar C [email protected]

Description

<Include a description of the change and why this change was made.>

<For each item, place an "x" in between [ and ] if true. Example: [x] (you can also check items in GitHub UI)>

<Create the PR as a Draft PR if it is only created to run CI checks.>

<Delete lines in <> tags before creating the PR.>

• Breaking change?
  • Breaking change - Does this PR cause a break in build or boot behavior?
  • Examples: Does it add a new library class or move a module to a different repo.
• Impacts security?
  • Security - Does this PR have a direct security impact?
  • Examples: Crypto algorithm change or buffer overflow fix.
• Includes tests?
  • Tests - Does this PR include any explicit test code?
  • Examples: Unit tests or integration tests.

How This Was Tested

<Describe the test(s) that were run to verify the changes.>

Integration Instructions

<Describe how these changes should be integrated. Use N/A if nothing is required.>

[abdattar]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4818

Added support for acpiview shell utility to parse and print SPMI table

Cc: Abdul Lateef Attar [email protected] Cc: Abner Chang [email protected] Cc: Paul Grimes [email protected]

Shankar, you need to add Signed-off-by: your name .
Also need to Cc maintainers.
Cc: Zhichao Gao [email protected]

[shkrc]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4818
Added support for acpiview shell utility to parse and print SPMI table
Cc: Abdul Lateef Attar [email protected] Cc: Abner Chang [email protected] Cc: Paul Grimes [email protected]

Shankar, you need to add Signed-off-by: your name . Also need to Cc maintainers. Cc: Zhichao Gao [email protected]

hi, i added in the commit but it did not reflect in the description. ill just edit the description

[lgao4]

Could you attach the dump result for SPMI table?

[abdattar]

@shkrc can you paste the acpiview -S SPMI output ?

[shkrc]

spmi.log
I have attached the log here

[shkrc]

Hi @lgao4 can you help review this patch?

[abdattar]

Hi @ZhichaoGao could you please merge the changes.

[abdattar]

could you please push the code changes?

[mergify]

PR can not be merged due to conflict. Please rebase and resubmit

[shkrc]

Hi @lgao4 @ZhichaoGao can you help review this patch?

[pierregondois]

I think you should check that:
[7:2] - Reserved (must be 0)

and to have a pretty print maybe, format the other bits with ParseAcpiBitFields():

[1] - I/O APIC/SAPIC interrupt (Global System Interrupt)
[0] - SCI triggered through GPE (use 0b for SSIF)
0 = not supported
1 = supported

Similar checks/formatting could be done regarding the GPE field:

 (Note: This field is valid only if Bit[0] of the InterruptType field is set.

and PCI Device Flag:

[7:1] - Reserved
[0] - PCI Device Flag. For PCI IPMI devices, this bit is set. For
non-PCI devices, this bit is cleared.

and other fields

[pierregondois]

It would be better to have these values in the MdePkg:

0 Reserved
1 Keyboard Controller Style (KCS)
2 Server Management Interface Chip (SMIC)
3 Block Transfer (BT)

and use a macro instead of 5 here

[pierregondois]

Also for this field:

This field must always be 01h to be compatible with any
software that implements previous versions of this spec.

[github-actions]

This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

[github-actions]

This pull request has been automatically been closed because it did not have any activity in 60 days and no follow up within 7 days after being marked stale. Thank you for your contributions.