base_parser: bugfix ifdef ifndef evaluation #698
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, ifdef / ifndef evaluation was done by replacing the macro with a "0" if it was not defined then when evaluating the conditional, it was just verified if the value was "0" or not. This left open a scenario where a macro is defined but defined as an empty string. In this scenario, the parser would successfully replace the macro value, but in replacing it with an empty string, if left bare conditionals (e.g. the line was only
!ifdef
or!ifndef
, which would cause an exception when attempting to evaluate that conditional.This commit updates the logic to only check if the macro is defined or not, replacing the value with a "0" if missing, or a "1" if existing. Now, regardless of the value of the macro, the conditional will always be valid.
fixed #697