improve verbosity flag override #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the verbosity command line argument for stuart commands in the following ways: 1. Moves when the flag is registered, so that the flag can be seen with the --help flag, even if a configuration file is not used. 2. Passes the verbosity flag to the edk2 build command. Additionally, as a part of (2), platforms can now set the --verbose flag in their platform configuration files via the EDK2_BUILD_VERBOSE env variable.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #938 +/- ##
==========================================
+ Coverage 78.75% 79.49% +0.74%
==========================================
Files 49 41 -8
Lines 4909 5063 +154
==========================================
+ Hits 3866 4025 +159
+ Misses 1043 1038 -5
|
makubacki
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the verbosity command line argument for stuart commands in the following ways:
Additionally, as a part of (2), platforms can now also control verbosity of EDKII Build in their platform configuration files via the EDK2_BUILD_VERBOSE env variable.
Resolves #935