Don't unshare after entering global namespace #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Global namespace is usually used to publicly apply mounts so calling unshare after entering root namespace is not desired behavior. This also keeps -M option same with Magisk.
tiann
approved these changes
Jan 23, 2025
rsuntk
pushed a commit
to rsuntk/KernelSU
that referenced
this pull request
Jan 24, 2025
Global namespace is usually used to publicly apply mounts so calling unshare after entering root namespace is not desired bahavior. This also keeps -M option same as Magisk.
backslashxx
pushed a commit
to backslashxx/KernelSU
that referenced
this pull request
Jan 24, 2025
Global namespace is usually used to publicly apply mounts so calling unshare after entering root namespace is not desired bahavior. This also keeps -M option same as Magisk.
selfmusing
pushed a commit
to selfmusing/USlenreK
that referenced
this pull request
Jan 24, 2025
Global namespace is usually used to publicly apply mounts so calling unshare after entering root namespace is not desired bahavior. This also keeps -M option same as Magisk.
selfmusing
pushed a commit
to selfmusing/USlenreK
that referenced
this pull request
Jan 24, 2025
Global namespace is usually used to publicly apply mounts so calling unshare after entering root namespace is not desired bahavior. This also keeps -M option same as Magisk.
backslashxx
pushed a commit
to backslashxx/KernelSU
that referenced
this pull request
Jan 24, 2025
Global namespace is usually used to publicly apply mounts so calling unshare after entering root namespace is not desired bahavior. This also keeps -M option same as Magisk.
backslashxx
pushed a commit
to backslashxx/KernelSU
that referenced
this pull request
Jan 29, 2025
Global namespace is usually used to publicly apply mounts so calling unshare after entering root namespace is not desired bahavior. This also keeps -M option same as Magisk.
mrsrimar22
added a commit
to KrustyCook/KernelSU
that referenced
this pull request
Jan 31, 2025
* 'main' of https://github.com/tiann/KernelSU: use ubuntu-22.04 to build avd kernel (tiann#2396) kernel: clear securebits (tiann#2387) Clean up umount targets (tiann#2386) Update busybox (tiann#2383) manager: Disable interactions for uninstalled & disabled module (tiann#2380) ksud: Fix warning unused import (tiann#2382) Avoid unnecessarily overriding capabilities (tiann#2381) build(deps): bump the npm group across 1 directory with 45 updates (tiann#2372) build(deps): bump the maven group across 1 directory with 11 updates (tiann#2361) [add device]: (tiann#2351) [add device]: (tiann#2356) Translations update from Hosted Weblate (tiann#2341) Add m23xq device kernel (tiann#2346) Update clippy.yml ksud: fix copy sparse file (tiann#2374) Don't unshare after entering global namespace (tiann#2373)
backslashxx
pushed a commit
to backslashxx/KernelSU
that referenced
this pull request
Feb 3, 2025
Global namespace is usually used to publicly apply mounts so calling unshare after entering root namespace is not desired bahavior. This also keeps -M option same as Magisk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global namespace is usually used to publicly apply mounts so calling unshare after entering root namespace is not desired bahavior. This also keeps -M option same as Magisk.