event: correctly parse TCP DESTROY events on kernels 5.11 and later #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linux commit 86d21fc74745 ("netfilter: ctnetlink: add timeout and protoinfo to
destroy events") added protoinfo to destroy events, but in doing so, changed
the logic used to assemble the ProtoInfoTCP payload, causing TCP flags to not be
sent as attributes.
This invalidated a long-standing assumption in the library that ProtoInfoTCP
would always contain at least 3 attributes. This commit relaxes the parser and
fixes the error returns of the SCTP and DCCP families.
TestConnListen now ranges over TCP, UDP, SCTP and DCCP families to verify if all
of NEW/UPDATE/DESTROY events can be parsed for all families.
Pull Request Test Coverage Report for Build 3752934169
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28, fixes torvalds/linux@86d21fc74745.