config(tidb): enable require code owner reviews

[Mini256]

Proposal

https://internals.tidb.io/t/topic/374/15?u=mini256

Related PR

pingcap/tidb#28249

How it works

Notice: When this PR is merged, the robot will automatically synchronize the configuration to the branch protection configuration of the GitHub repository.

We enable the CODEOWNERS to implement our config review mechanism by turning on the require_code_owner_reviews option.

But GitHub will require us to enable the required_approving_review_count option at the same time, and the minimum value of this option is 1.

It will require our PR to pass through at least one reviewer with write permission before it can be merged. However, our team reviewer only has read permission in the repository settings.

Notice: After enabling this option, if the PR does not get the approval of at least one committer or maintainer (whose role with write permission) before the committer comments /merge, the committer needs to perform an additional approve operation, or GitHub will prompt this.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• tisonkun

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[Mini256]

/hold

[Mini256]

\cc tisonkun

Please also take a look at this PR, it will turn on the required_approving_review_count option at the same time if this is acceptable.

cc: @qw4990 @bb7133 @XuHuaiyu @cfzjywxk @morgo

Referenced document: https://github.com/kubernetes/test-infra/tree/master/prow/cmd/branchprotector

[tisonkun]

LGTM.

@bb7133 @morgo @XuHuaiyu @qw4990 @cfzjywxk please take a look and approve explicitly if it looks good to you.

[morgo]

LGTM

[bb7133]

LGTM

[ti-chi-bot]

@bb7133: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[bb7133]

/merge

[ti-chi-bot]

@bb7133: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[Mini256]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 3db71cd

[Mini256]

/unhold

[ti-chi-bot]

@Mini256: Updated the config configmap in namespace prow at cluster default using the following files:

• key config.yaml using file prow/config/config.yaml

In response to this:

Proposal

https://internals.tidb.io/t/topic/374/15?u=mini256

Related PR

pingcap/tidb#28249

How it works

Notice: When this PR is merged, the robot will automatically synchronize the configuration to the branch protection configuration of the GitHub repository.

We enable the CODEOWNERS to implement our config review mechanism by turning on the require_code_owner_reviews option.

But GitHub will require us to enable the required_approving_review_count option at the same time, and the minimum value of this option is 1.

It will require our PR to pass through at least one reviewer with write permission before it can be merged. However, our team reviewer only has read permission in the repository settings.

Notice: After enabling this option, if the PR does not get the approval of at least one committer or maintainer (whose role with write permission) before the committer comments /merge, the committer needs to perform an additional approve operation, or GitHub will prompt this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.