executor: fix data race in the IndexNestedLoopHashJoin (pingcap#31731)

close pingcap#31467
ti-chi-bot · Jan 17, 2022 · ca7ff0a · ca7ff0a
1 parent 6db56bb
commit ca7ff0a
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/executor/index_lookup_hash_join.go b/executor/index_lookup_hash_join.go
@@ -498,7 +498,9 @@ func (iw *indexHashJoinInnerWorker) run(ctx context.Context, cancelFunc context.
 			break
 		}
 		err := iw.handleTask(ctx, task, joinResult, h, resultCh)
-		if err != nil {
+		if err != nil && !task.keepOuterOrder {
+			// Only need check non-keep-outer-order case because the
+			// `joinResult` had been sent to the `resultCh` when err != nil.
 			joinResult.err = err
 			break
 		}