Adjust CALDAV.test_connection to return a boolean or raise an exception with a message. (Fixes #802) #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on with a message. (Fixes #802)
MelissaAutumn
commented
Dec 19, 2024
| @@ -51,6 +51,7 @@ const isError = props.type === 'error'; | |||
| font-size: 0.8125rem; | |||
| font-weight: 700; | |||
| line-height: 1; | |||
| white-space: pre; | |||
There was a problem hiding this comment.
For our sweet newline character in the localization message
There was a problem hiding this comment.
Ah, it is intended. Thanks.
devmount
approved these changes
Dec 20, 2024
| remote-calendar-connection-error = The remote calendar could not be reached. Please verify your connection information and try again. | ||
| remote-calendar-connection-error = The remote calendar could not be reached due to {$reason}. | ||
|
|
||
| Please verify your connection information and try again. |
There was a problem hiding this comment.
Is this intended to be indented?
| @@ -51,6 +51,7 @@ const isError = props.type === 'error'; | |||
| font-size: 0.8125rem; | |||
| font-weight: 700; | |||
| line-height: 1; | |||
| white-space: pre; | |||
There was a problem hiding this comment.
Ah, it is intended. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hopefully gives the user a little more feedback on what went wrong with their connection attempt.
Screenshots