Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#490) Add an automated production sanity test #792

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

rwood-moz
Copy link
Contributor

@rwood-moz rwood-moz commented Dec 13, 2024

This PR adds a production sanity E2E test which verifies the splashscreen appears, and we are able to sign-in to Appointment production. The suite can be run on your local machine against locally-installed browsers or against browsers located in the BrowserStack Automate cloud platform.

For more details please see the included /test/e2e/README file. If you want to try running the tests in BrowserStack and don't have a BrowserStack account yet let me know and I can get you set up :)

@rwood-moz rwood-moz linked an issue Dec 13, 2024 that may be closed by this pull request
@rwood-moz rwood-moz added the testing Issues specific to automated testing label Dec 13, 2024
@rwood-moz rwood-moz force-pushed the testing/490-post-deployment-e2e-test branch from 3c9b934 to eaf2da4 Compare December 13, 2024 22:56
@rwood-moz rwood-moz force-pushed the testing/490-post-deployment-e2e-test branch from eaf2da4 to e676e21 Compare December 13, 2024 22:58
@rwood-moz rwood-moz force-pushed the testing/490-post-deployment-e2e-test branch from e676e21 to ff43108 Compare December 13, 2024 23:55
@rwood-moz rwood-moz force-pushed the testing/490-post-deployment-e2e-test branch from ff43108 to 6eb0d1d Compare December 13, 2024 23:57
@rwood-moz rwood-moz force-pushed the testing/490-post-deployment-e2e-test branch from 6eb0d1d to 4e37947 Compare December 14, 2024 00:06
@rwood-moz rwood-moz force-pushed the testing/490-post-deployment-e2e-test branch from 4e37947 to 04e5570 Compare December 14, 2024 00:10
Copy link
Member

@MelissaAutumn MelissaAutumn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good, I've got some comments but nothing blocking (stuff can be moved to another issue.)

One question though, it seems like you're building a second project within frontend. Should we consolidate it with frontend's package.json and use a env.test (with env.test.example for the repo) and dev dependencies?

I'm okay with two projects if that's easier to manage, but we'll need to make sure ides still detect the linting rules and such okay.

test/e2e/.env.example Show resolved Hide resolved
test/e2e/README.md Outdated Show resolved Hide resolved
test/e2e/README.md Outdated Show resolved Hide resolved
test/e2e/README.md Show resolved Hide resolved
Copy link
Collaborator

@devmount devmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @rwood-moz! Thank you!

@rwood-moz
Copy link
Contributor Author

Changes looks good, I've got some comments but nothing blocking (stuff can be moved to another issue.)

One question though, it seems like you're building a second project within frontend. Should we consolidate it with frontend's package.json and use a env.test (with env.test.example for the repo) and dev dependencies?

I'm okay with two projects if that's easier to manage, but we'll need to make sure ides still detect the linting rules and such okay.

Thanks for your feedback Mel, appreciated! I prefer to keep the E2E tests in their own project because they are testing the entire application and need both the frontend and backend to be running; so I created the new test/e2e folder at the root level not under the frontend or backend folders - I hope that's ok!

@MelissaAutumn
Copy link
Member

Changes looks good, I've got some comments but nothing blocking (stuff can be moved to another issue.)
One question though, it seems like you're building a second project within frontend. Should we consolidate it with frontend's package.json and use a env.test (with env.test.example for the repo) and dev dependencies?
I'm okay with two projects if that's easier to manage, but we'll need to make sure ides still detect the linting rules and such okay.

Thanks for your feedback Mel, appreciated! I prefer to keep the E2E tests in their own project because they are testing the entire application and need both the frontend and backend to be running; so I created the new test/e2e folder at the root level not under the frontend or backend folders - I hope that's ok!

Yep root level is okay, I just missed that. I thought it was under frontend. That works for me!

@rwood-moz rwood-moz merged commit 351479d into main Dec 16, 2024
4 checks passed
@rwood-moz rwood-moz deleted the testing/490-post-deployment-e2e-test branch December 16, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Issues specific to automated testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add automated, post-deployment sanity tests
3 participants