-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#490) Add an automated production sanity test #792
Conversation
3c9b934
to
eaf2da4
Compare
eaf2da4
to
e676e21
Compare
e676e21
to
ff43108
Compare
ff43108
to
6eb0d1d
Compare
6eb0d1d
to
4e37947
Compare
4e37947
to
04e5570
Compare
04e5570
to
b4fa3c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good, I've got some comments but nothing blocking (stuff can be moved to another issue.)
One question though, it seems like you're building a second project within frontend. Should we consolidate it with frontend's package.json and use a env.test (with env.test.example for the repo) and dev dependencies?
I'm okay with two projects if that's easier to manage, but we'll need to make sure ides still detect the linting rules and such okay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @rwood-moz! Thank you!
Thanks for your feedback Mel, appreciated! I prefer to keep the E2E tests in their own project because they are testing the entire application and need both the frontend and backend to be running; so I created the new |
Yep root level is okay, I just missed that. I thought it was under frontend. That works for me! |
This PR adds a
production sanity
E2E test which verifies the splashscreen appears, and we are able to sign-in to Appointment production. The suite can be run on your local machine against locally-installed browsers or against browsers located in the BrowserStack Automate cloud platform.For more details please see the included
/test/e2e/README
file. If you want to try running the tests in BrowserStack and don't have a BrowserStack account yet let me know and I can get you set up :)