-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle missing vevent attributes #751
Handle missing vevent attributes #751
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can we actually test this? Our current tests (correct me if I'm wrong) always fake the list_events()
function. Is there a way to acutally test the caldav connector?
We can create some mock ical files, and have list_events return those files initialized into icalendar (iirc) instead. It's a little confusing because I think python-caldav handles the server requests and responses, but then it uses icalendar for the calendar/event objects...I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Good idea, I'll play around with that a bit and create some tests. Those should live in test_calendar.py rather than test_appointment.py, right? |
Yep probably as a unit test if you want to test the functions directly. Let me know if you run into any issues there! |
Postponed the test creation for now. |
Description of the Change
This change ignores all remote events, that don't have a
dtstart
or neither adtend
norduration
. Also the event title gets a default value, ifsummary
is missing.Benefits
Wider range of supported caldav servers.
Applicable Issues
Fixes #741