Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unintended keyboard popup when navigating back to main screen #1686

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Feb 7, 2025

Pull Request Description

This PR fixes an issue described in #1684 and #1110 where the keyboard would show up on the main pages after using search. I mainly tested this on an Android emulator as iOS doesn't seem to exhibit this issue (difficult to reproduce)

Note: this fix still keeps the old behaviour of double-tapping the search icon to open up the keyboard!

Issue Being Fixed

Issue Number: #1684, #1110

Screenshots / Recordings

Original Issue

original.mp4

Fixed Issue

fixed.mp4

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@micahmo
Copy link
Member

micahmo commented Feb 7, 2025

LGTM!

BTW, to fully fix #1110, I believe we also need to minimize the keyboard when we navigate away from the search page in any way for example, as mentioned in that issue, clicking a search result. This behavior is a little annoying.

  • Search for something (do not minimize keyboard)
  • Click a result (keyboard automatically goes away)
  • Go back
    • Keyboard automatically comes back :(

I believe there are some more scenarios mentioned in the bug. But that can be separate. I think this fully fixes #1684.

@hjiangsu
Copy link
Member Author

hjiangsu commented Feb 7, 2025

I believe we also need to minimize the keyboard when we navigate away from the search page in any way

Ahh I see - this can definitely be fixed in a separate PR then as it's a bit more involved! I'll keep #1110 open until all the issues related to the Search page are resolved.

@hjiangsu hjiangsu merged commit a477b29 into develop Feb 7, 2025
1 check passed
@hjiangsu hjiangsu deleted the fix/unfocus-keyboard branch February 7, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants