Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment bottom sheet redesign #1654

Merged
merged 10 commits into from
Jan 16, 2025
Merged

Comment bottom sheet redesign #1654

merged 10 commits into from
Jan 16, 2025

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Jan 2, 2025

Pull Request Description

This PR updates our comment actions bottom sheet to match the redesigned post bottom sheet actions introduced in #1567. A few things to note:

  • A new category "Comment" has been added to the bottom sheet, and I've moved the text actions and report comment actions into this new category
  • I've refactored some of the existing post bottom sheet actions to be more generic so that it can be re-used within the comment bottom action sheet. In particular, I've refactored the user, instance, and share bottom sheets to work with both posts and comments.

This is a check-list of all the actions that have been updated to work with the new comment bottom sheet. If you notice any missing actions, please let me know!

General (Quick Actions)

  • Upvote
  • Downvote
  • Save
  • Reply
  • Edit

Comment

  • Select comment text
  • View comment source text
  • View modlog entries
  • Report comment (the report dialog was refactored to match the post report dialog)
  • Edit comment
  • Delete or restore comment
  • Remove or restore comment as a moderator (to be implemented)

User

  • Visit user profile
  • Block or unblock user
  • Add user label (this is also retroactively added to the post bottom action sheets)
  • Ban or unban user from community
  • Add or remove user as a community moderator

Instance

  • Visit user instance
  • Block or unblock user instance

Sharing

  • Sharing comment link
  • Sharing comment link for own instance

This is still in draft as I need to add in the moderator actions to remove/restore comments.

After briefly looking into adding in the comment moderator functions, I've decided to hold off for now until a future PR!

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

These are some initial screenshots, subject to change

Guest Account Moderator
simulator_screenshot_B9E6A081-E4EB-4811-B992-FE2DBD73D7A8 simulator_screenshot_B117CDE6-5F14-4451-AB51-53EEA22CD7D5 simulator_screenshot_FBC4D6D3-E2CF-478F-B4F4-02B13EEFC660
simulator_screenshot_D4236893-18E4-4292-9228-B00B8745FBFD simulator_screenshot_B7D0C014-1134-4DD3-8B9F-72B9FDCE9F11 simulator_screenshot_54C23216-8C20-4CE2-AB13-C86A906A4800
simulator_screenshot_4930BC44-EDB5-439D-8A22-0DDC11BDB2F4 simulator_screenshot_3F64602A-C78D-4276-BA94-796D5726CE8B simulator_screenshot_A5AB5E05-939D-4165-8C41-4C51FA505B90
simulator_screenshot_E211051D-4F7B-4955-97D9-661EE9BF973B simulator_screenshot_0197657E-676B-41AE-B2B1-C32A1374717B simulator_screenshot_8A14EACF-F323-4EDD-8EB3-1ED9D01F84C8
simulator_screenshot_503CD76F-FA5C-42EB-B979-A6766B4E97FB simulator_screenshot_4B571D8F-38FC-4E12-A95F-A2F627DA94B3 simulator_screenshot_3310FAB7-03A8-4BDD-A8BE-29B054470B73

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu hjiangsu marked this pull request as ready for review January 16, 2025 01:33
@hjiangsu
Copy link
Member Author

@micahmo This should be ready to go now! I've opted to delay implementation for the additional comment moderator actions (remove/restore comment) until later since this PR is already quite large.

Don't worry about reviewing the code (unless you want to of course). However, do let me know if you run into any issues or notice anything missing from this redesign that I may have missed!

@micahmo
Copy link
Member

micahmo commented Jan 16, 2025

Sounds good to me! Just based on the screenshots, everything looks good!

@hjiangsu hjiangsu merged commit e6b2e0b into develop Jan 16, 2025
1 check passed
@hjiangsu hjiangsu deleted the refactor/comment-bottom-sheet branch January 16, 2025 16:58
@micahmo
Copy link
Member

micahmo commented Jan 16, 2025

Hey @hjiangsu, just one small thing I noticed. On the "Instance Actions" subpage, it's a little confusing that the subtitle shows two instances (presumably for the post and for the user) but only actions for one (the user). I guess we should either show only the user's instance in the subtitle, or have actions for the post instance too. What do you think?

image

@hjiangsu
Copy link
Member Author

That makes sense! I'll just keep the user instance there - that was a remnant when I copied the logic from the post bottom action sheet.

@hjiangsu
Copy link
Member Author

I created a PR for this change: #1658

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants