-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment bottom sheet redesign #1654
Conversation
…bottom sheet quick actions
…o comment bottom sheet
…efreshing properly
@micahmo This should be ready to go now! I've opted to delay implementation for the additional comment moderator actions (remove/restore comment) until later since this PR is already quite large. Don't worry about reviewing the code (unless you want to of course). However, do let me know if you run into any issues or notice anything missing from this redesign that I may have missed! |
Sounds good to me! Just based on the screenshots, everything looks good! |
Hey @hjiangsu, just one small thing I noticed. On the "Instance Actions" subpage, it's a little confusing that the subtitle shows two instances (presumably for the post and for the user) but only actions for one (the user). I guess we should either show only the user's instance in the subtitle, or have actions for the post instance too. What do you think?
|
That makes sense! I'll just keep the user instance there - that was a remnant when I copied the logic from the post bottom action sheet. |
I created a PR for this change: #1658 |
Pull Request Description
This PR updates our comment actions bottom sheet to match the redesigned post bottom sheet actions introduced in #1567. A few things to note:
This is a check-list of all the actions that have been updated to work with the new comment bottom sheet. If you notice any missing actions, please let me know!
General (Quick Actions)
Comment
User
Instance
Sharing
This is still in draft as I need to add in the moderator actions to remove/restore comments.After briefly looking into adding in the comment moderator functions, I've decided to hold off for now until a future PR!
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
These are some initial screenshots, subject to change
Checklist
semanticLabel
s where applicable for accessibility?