-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Drift database on Web #1585
Conversation
You're correct, we're only using On a different note, is it okay if I apply some modifications to this PR? I think I might be able to simplify some of the logic further! |
Yep go for it, do you need permissions? |
Thanks, I can make a commit directly to this branch to keep things in order! |
I'll list out the changes I made here (f92770a):
@gwbischof Could you run a few tests on your end and let me know if this builds properly for all the platforms you mentioned above? Thanks! |
Looks good, I tested on all of my platforms. There are some handled exceptions on web, but its building and it looks like its working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR configures Drift to work on Web, mobile, and desktop. It also removes the sqflite and sqlite3 deps.
Do we need the sqflite and sqlite3 deps? It looks like they are only being used for migrating from the the old stile database. Can we use Drift to connect to the old style database and migrate it to the new one?
I tested the app on macos, web, android, and ios, it apprears to be working correctly.