Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collapse animation with deferred comments #1429

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Jun 5, 2024

Pull Request Description

This PR fixes an issue where deferred comments were not being collapsed properly, and thus was always shown even when the parent comment was collapsed.

Collapsing comment threads does not show any animation

@micahmo I'm not sure if this also fixes this issue, so let me know! For me, it feels like if "Hide Parent Comment when Collapsed" is enabled, the animation is instantaneous whereas if it's disabled, it feels like a more proper "shrinking" animation.

Issue Being Fixed

Issue Number: #1413

Screenshots / Recordings

I'm trying out the macOS build here, so the recording is using that!

Screen.Recording.2024-06-04.at.6.04.58.PM.mov

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this definitely fixes the problem with deferred comments!

With "Hide Parent Comment when Collapsed" disabled, there is still no animation for collapsing full threads, and even collapsing deferred comments seems to have an interesting curve.

qemu-system-x86_64_q1bPNlWFw9.mp4

@hjiangsu
Copy link
Member Author

hjiangsu commented Jun 5, 2024

Thanks for confirming! I'll try to fix that in a separate PR

@hjiangsu hjiangsu merged commit 0d707e0 into develop Jun 5, 2024
1 check passed
@hjiangsu hjiangsu deleted the fix/comment-collapse branch June 5, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants