Fix optimistic voting #1392
Merged
Fix optimistic voting #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjiangsu
approved these changes
May 30, 2024
There was a problem hiding this comment.
That's funny - I also noticed this issue when I was working on the post page refactor and made the changes there (although I did miss lib/post/utils/post.dart) 😅
Anyways, LGTM!
|
Ah, I see we had very similar fixes! Not sure how much longer your refactor will take but it doesn't hurt to get this in now for existing usage. 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR fixes a tiny issue with post and comment upvoting where separate counts would not update optimistically, but combined counts (and colors) would.