Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autosize to name styling #1254

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Mar 29, 2024

Pull Request Description

This PR is a followup to #1227 wherein it was mentioned that instances of AutoSizeText don't support the new name styles yet. Fortunately, AutoSizeText supports RichText, so I was able to integrate it directly into the full name widgets with a new option.

Review without whitespace.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before (no styling) UserFullNameWidget without AutoSize (styled but cut off) UserFullNameWidget with AutoSize (styled and no cutoff)
image image image

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit b9ee94a into thunder-app:develop Mar 31, 2024
1 check passed
@micahmo micahmo deleted the fix/auto-size-with-styling branch March 31, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants