Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load small instances #1228

Merged
merged 2 commits into from
Mar 23, 2024
Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Mar 23, 2024

Pull Request Description

This PR fixes an issue where the instance viewer would spin indefinitely when it should have "finished" loading.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before

qemu-system-x86_64_rM8vzgKqNA.mp4

After

qemu-system-x86_64_zWapeJXLXz.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion - could we extract the limit into a constant and use that instead? It'll make it easier to adjust the limit parameter in the future if we need to!

@micahmo
Copy link
Member Author

micahmo commented Mar 23, 2024

Done!

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@hjiangsu hjiangsu merged commit f3d26f6 into thunder-app:develop Mar 23, 2024
1 check passed
@micahmo micahmo deleted the fix/small-instances branch March 23, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants