Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created new feature request, and bug report templates. #1100

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

K4LCIFER
Copy link
Contributor

Pull Request Description

Updated the feature request, and bug report templates so that they are more user friendly -- they now use GitHub's feature request templates.

Issue Being Fixed

The old one's weren't the most fun to interract with. The user needed to delete text and replace it. The updated templates have input boxes that are much more user friendly.

Issue Number: N/A

Screenshots / Recordings

N/A

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@K4LCIFER
Copy link
Contributor Author

This is my first pull request for this repo, so I'm not sure how to answer the checklist -- I would appreciate some insight on that.

@K4LCIFER
Copy link
Contributor Author

I just noticed upon the creation of this pull request that a template could probably also be made for pull requests.

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this @K4LCIFER

@hjiangsu hjiangsu merged commit 6a73875 into thunder-app:develop Feb 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants