Exif applies only for JPEG format #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heynemann
added a commit
that referenced
this pull request
Nov 27, 2014
Exif applies only for JPEG format
scorphus
pushed a commit
that referenced
this pull request
Jan 31, 2022
Exif applies only for JPEG format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we preserve Exif info and we ask for PNG output with filter format(png), thumbor crash:
2014-11-27 15:50:21 thumbor:ERROR ERROR: Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/tornado/web.py", line 1320, in _stack_context_handle_exception
raise_exc_info((type, value, traceback))
File "/usr/local/lib/python2.7/dist-packages/tornado/stack_context.py", line 302, in wrapped
ret = fn(_args, *_kwargs)
File "/usr/local/lib/python2.7/dist-packages/thumbor/loaders/http_loader.py", line 49, in return_contents
callback(response.body)
File "/usr/local/lib/python2.7/dist-packages/thumbor/handlers/init.py", line 333, in handle_loader_loaded
callback(normalized, engine=self.context.request.engine)
File "/usr/local/lib/python2.7/dist-packages/thumbor/handlers/init.py", line 99, in callback
self.filters_runner.apply_filters(thumbor.filters.PHASE_AFTER_LOAD, transform)
File "/usr/local/lib/python2.7/dist-packages/thumbor/filters/init.py", line 81, in apply_filters
callback()
File "/usr/local/lib/python2.7/dist-packages/thumbor/handlers/init.py", line 97, in transform
Transformer(self.context).transform(after_transform_cb)
File "/usr/local/lib/python2.7/dist-packages/thumbor/transformer.py", line 88, in transform
self.smart_detect()
File "/usr/local/lib/python2.7/dist-packages/thumbor/transformer.py", line 156, in smart_detect
self.do_image_operations()
File "/usr/local/lib/python2.7/dist-packages/thumbor/transformer.py", line 199, in do_image_operations
self.done_callback()
File "/usr/local/lib/python2.7/dist-packages/thumbor/handlers/init.py", line 141, in after_transform
self.filters_runner.apply_filters(thumbor.filters.PHASE_POST_TRANSFORM, finish_callback)
File "/usr/local/lib/python2.7/dist-packages/thumbor/filters/init.py", line 91, in apply_filters
exec_one_filter()
File "/usr/local/lib/python2.7/dist-packages/thumbor/filters/init.py", line 90, in exec_one_filter
f.run(exec_one_filter)
File "/usr/local/lib/python2.7/dist-packages/thumbor/filters/init.py", line 201, in run
callback()
File "/usr/local/lib/python2.7/dist-packages/thumbor/filters/init.py", line 86, in exec_one_filter
callback()
File "/usr/local/lib/python2.7/dist-packages/thumbor/handlers/init.py", line 196, in finish_request
results = context.request.engine.read(image_extension, quality)
File "/usr/local/lib/python2.7/dist-packages/opencv_engine/engine.py", line 145, in read
img = JpegFile.fromString(data)
File "/usr/local/lib/python2.7/dist-packages/pexif.py", line 981, in fromString
return JpegFile(StringIO.StringIO(str), "from buffer", mode=mode)
File "/usr/local/lib/python2.7/dist-packages/pexif.py", line 1015, in init
"should be <%s>" % (soi_marker, SOI_MARKER))
InvalidFile: Error reading soi_marker. Got <?P> should be <??>