Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xtask: add no_infer_bin_path flag #252

Merged
merged 1 commit into from
Feb 23, 2024
Merged

xtask: add no_infer_bin_path flag #252

merged 1 commit into from
Feb 23, 2024

Conversation

gabriele-0201
Copy link
Contributor

remove the ci flag and set the default behavior to add binaries to the path and CONSTANTS_MANIFEST to environment variables

Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

remove the ci flag and set the default behavior to add binaries to the path and CONSTANTS_MANIFEST to environment variables
Copy link
Contributor

@pepyakin pepyakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, way better than prior proposals.

However, it still modifies the env vars of the process. This is fine for now, just a bit sketchy. A cleaner approach would be to supply env variables to each shell invocation.

@@ -57,9 +57,11 @@ pub mod test {

#[derive(Debug, Args)]
pub struct Params {
/// If the test is executed in CI
/// By default, binary paths are extracted using the `cargo metadata` command under the key `target_directory`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: paths to compiled binaries

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: no need details about target I suppose

@pepyakin pepyakin merged commit ad11422 into main Feb 23, 2024
6 checks passed
@pepyakin pepyakin deleted the gab_no_infer_bin_path branch February 23, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants