add rentable_by filter #1204
add rentable_by filter #1204
Conversation
…by a twin id or nodes available to rent.
Omarabdul3ziz
requested review from
muhamadazmy,
mariobassem,
ashraffouda,
rawdaGastan,
AbdelrahmanElawady,
xmonader,
sameh-farouk and
Eslam-Nawara
as code owners
grid-proxy/pkg/types/nodes.go
Outdated
| @@ -141,7 +141,8 @@ type NodeFilter struct { | |||
| OwnedBy *uint64 `schema:"owned_by,omitempty"` | |||
| Rented *bool `schema:"rented,omitempty"` | |||
| RentedBy *uint64 `schema:"rented_by,omitempty"` | |||
| AvailableFor *uint64 `schema:"available_for,omitempty"` | |||
| RentableBy *uint64 `schema:"rentable_by,omitempty"` // rented by twin or rentable | |||
There was a problem hiding this comment.
RentedBy instead of RentableBy no?
There was a problem hiding this comment.
rentedby is already a functional filter returns all the nodes rented by a specific twin.
rentableby is a new filter that should return all the nodes rented by a specific twin + all the nodes available to rent
There was a problem hiding this comment.
rentedby is already a functional filter returns all the nodes rented by a specific twin.
rentableby is a new filter that should return all the nodes rented by a specific twin + all the nodes available to rent. somehow combining rentable and rentedby
There was a problem hiding this comment.
How is that different from AvailableFor?
There was a problem hiding this comment.
available_for returns the nodes rented by a twin id + the shared nodes. (available to deploy on)
rentable_for returns the nodes rented by a twin id + the rentable nodes. (rented or available to rent)
There was a problem hiding this comment.
Tb bos :D let's make it rentable_or_rented_by :D
Checklist