Development support volumes in tfrobot #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowangamal
requested review from
muhamadazmy,
mariobassem,
ashraffouda,
rawdaGastan,
Omarabdul3ziz,
AbdelrahmanElawady and
xmonader
as code owners
Eslam-Nawara
requested changes
Aug 18, 2024
tfrobot/example/conf.yaml
Outdated
| @@ -19,6 +19,9 @@ vms: | |||
| ssd: # list of ssd storage needed to be mounted to the vm | |||
| - size: 15 # size in GB, min 15 GB | |||
| mount_point: /mnt/ssd | |||
| vol: # list of volume storage needed to be mounted to the vm | |||
tfrobot/pkg/deployer/deployer.go
Outdated
| @@ -260,7 +260,7 @@ func buildDeployments(vms []Vms, nodesIDs []int, sshKeys map[string]string) grou | |||
| return groupDeploymentsInfo{vmDeployments: vmDeployments, networkDeployments: networkDeployments} | |||
| } | |||
|
|
|||
| func parseDisks(name string, disks []Disk) (disksWorkloads []workloads.Disk, mountsWorkloads []workloads.Mount) { | |||
| func parseDisksAndVolumes(name string, disks []Disk, volumes []Volume) (disksWorkloads []workloads.Disk, volWorkloads []workloads.Volume, mountsWorkloads []workloads.Mount) { | |||
There was a problem hiding this comment.
use two separate functions to parse disks and volumes
Co-authored-by: Eslam Nawara <[email protected]>
Eslam-Nawara
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supporting Volumes in tfrobot, and editing the deployments accordingly
Changes
types.gointfrobot/pkg/deployerparser.go,validator.go,parser_test.gointfrobot/internal/parserREADME.mdintfrobotconfig.yamlintfrobot/exampleRelated Issues
issue
Checklist