Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extended Node features #720

Closed
muhamadazmy opened this issue Jun 1, 2023 · 1 comment
Closed

extended Node features #720

muhamadazmy opened this issue Jun 1, 2023 · 1 comment
Labels
priority_major type_feature New feature or request
Milestone

Comments

@muhamadazmy
Copy link
Member

A node need to be able to set an extended set of flags for itself that should be available on chain (public)

Suggestion

Instead of modifying the node object itself (that require expensive migration) we can have a dynamic set of feature flags separate from the node itself.

The feature flags should be a dynamic type a list of tuples (key, value) means that a node can have a set of features that can be extended when needed without any required migration. I prefer to have a list of tuples over a map so we can have the same key multiple times (say if we have 2 different GPUs attached to a node)

For example:
A node features can look like

[
   ("gpu", "radeon:RX-6800"),
   ("gpu", " nvidia:RTX-3060"),
   ...
]
@muhamadazmy muhamadazmy added priority_major type_feature New feature or request labels Jun 1, 2023
@DylanVerstraete DylanVerstraete added this to the 2.5.0 milestone Jun 1, 2023
@xmonader xmonader moved this to In Progress in 3.11.x Jun 7, 2023
@DylanVerstraete
Copy link
Contributor

Extra node features or not needed for the GPU story to complete so will be closing this. See: #725

@github-project-automation github-project-automation bot moved this from In Progress to Done in 3.11.x Jun 7, 2023
@DylanVerstraete DylanVerstraete removed this from 3.11.x Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority_major type_feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants