Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Prevent PMREM to break when missing textures #875

Merged
merged 4 commits into from
Mar 23, 2024
Merged

WebGPURenderer: Prevent PMREM to break when missing textures #875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b5e76a
WebGPURenderer: Prevent PMREM to break when missing textures
Methuselah96 Mar 23, 2024
5158b96
Add examples
Methuselah96 Mar 23, 2024
6577edb
Update patch
Methuselah96 Mar 23, 2024
393f65e
Delete examples
Methuselah96 Mar 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples-testing/changes.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14401,7 +14401,7 @@ index 3a13ab5..2850b1b 100644
}
});
diff --git a/examples-testing/examples/webgpu_parallax_uv.ts b/examples-testing/examples/webgpu_parallax_uv.ts
index 414dd0e..af4f4a6 100644
index 3021949..4ba3502 100644
--- a/examples-testing/examples/webgpu_parallax_uv.ts
+++ b/examples-testing/examples/webgpu_parallax_uv.ts
@@ -5,9 +5,9 @@ import WebGPURenderer from 'three/addons/renderers/webgpu/WebGPURenderer.js';
Expand Down
2 changes: 1 addition & 1 deletion three.js
Open in desktop
Submodule three.js updated 7 files
+16 −0 examples/jsm/loaders/RGBMLoader.js
+12 −0 examples/jsm/nodes/pmrem/PMREMNode.js
+6 −6 examples/jsm/renderers/common/extras/PMREMGenerator.js
+7 −9 examples/webgpu_cubemap_adjustments.html
+4 −3 examples/webgpu_cubemap_dynamic.html
+5 −7 examples/webgpu_cubemap_mix.html
+9 −9 examples/webgpu_parallax_uv.html
5 changes: 5 additions & 0 deletions types/three/examples/jsm/loaders/RGBMLoader.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ export class RGBMLoader extends DataTextureLoader {
onError?: (event: ErrorEvent) => void,
): CubeTexture;

loadCubemapAsync(
urls: string[],
onProgress?: (event: ProgressEvent) => void,
): Promise<CubeTexture>;

parse(buffer: ArrayBuffer): RGBM;

setDataType(dataType: TextureDataType): this;
Expand Down
Loading