Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timer: add timestamp param and FixedTimer #807

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Timer: add timestamp param and FixedTimer #807

merged 3 commits into from
Feb 6, 2024

Conversation

vanruesc
Copy link
Contributor

@vanruesc vanruesc commented Feb 3, 2024

This PR adds the optional timestamp parameter to the update method (mrdoob/three.js#27421). The fixed delta logic has also been moved into a separate FixedTimer class (mrdoob/three.js#27423).

Methuselah96
Methuselah96 approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@Methuselah96 Methuselah96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Not sure how I missed these changes.

@Methuselah96 Methuselah96 merged commit 734c87b into three-types:master Feb 6, 2024
3 checks passed
@vanruesc vanruesc deleted the update-timer branch August 29, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Methuselah96 Methuselah96 Methuselah96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vanruesc @Methuselah96