Use this
return type for Matrix4
in-place functions
#705
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Closes #704.
Consider the following example:
This example doesn't compile, because the subclass type is erased by the
Matrix4
return type of the.multiply
function.Solution
Instead of
Matrix4
, we now usethis
as return type for functions which returnthis
.I used the Matrix4 documentation on threejs.org to determine which return types should be
this
.