Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on*Render methods to be member functions instead of properties #639

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix on*Render methods to be member functions instead of properties #639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions types/three/src/core/Object3D.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,14 +235,14 @@ export class Object3D<TEventMap extends Object3DEventMap = Object3DEventMap> ext
* are not renderable and thus this callback is not executed for such objects.
* @defaultValue `() => {}`
*/
onBeforeRender: (
onBeforeRender(
renderer: WebGLRenderer,
scene: Scene,
camera: Camera,
geometry: BufferGeometry,
material: Material,
group: Group,
) => void;
): void;

/**
* An optional callback that is executed immediately after a 3D object is rendered.
Expand All @@ -254,14 +254,14 @@ export class Object3D<TEventMap extends Object3DEventMap = Object3DEventMap> ext
* are not renderable and thus this callback is not executed for such objects.
* @defaultValue `() => {}`
*/
onAfterRender: (
onAfterRender(
renderer: WebGLRenderer,
scene: Scene,
camera: Camera,
geometry: BufferGeometry,
material: Material,
group: Group,
) => void;
): void;

/**
* The default {@link up} direction for objects, also used as the default position for {@link THREE.DirectionalLight | DirectionalLight},
Expand Down