Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(Matrix4.d.ts): Overloads is needed for setPosition() #624

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Fix(Matrix4.d.ts): Overloads is needed for setPosition() #624

merged 1 commit into from
Oct 22, 2023

Conversation

ycw
Copy link
Contributor

@ycw ycw commented Oct 2, 2023 •
edited
Loading

Why

setPosition() accepts these 2 usages:

m4.setPosition(v) // Vector3
m4.setPosition(x,y,z) // 3 numbers, ALL REQUIRED

But current dts accepts extra usages which are illegal:

m4.setPosition(x,y) // omit z
m4.setPosition(x) // omit y z

This PR forbids the illegal usages.

Checklist

  • Checked the target branch (current goes master, next goes dev)
  • Ready to be merged

Methuselah96
Methuselah96 approved these changes Oct 22, 2023
View reviewed changes
Copy link
Contributor

@Methuselah96 Methuselah96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Methuselah96 Methuselah96 merged commit 28258df into three-types:master Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Methuselah96 Methuselah96 Methuselah96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ycw @Methuselah96