Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: toCreasedNormals(): call toNonIndexed() only on non-indexed geometries #564

Merged
merged 2 commits into from
Jul 28, 2023
Merged

fix: toCreasedNormals(): call toNonIndexed() only on non-indexed geometries #564

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef9874c
fix: toCreasedNormals(): call toNonIndexed() only on non-indexed geom…
Methuselah96 Jul 18, 2023
4cb390e
Docs: Clarify units for toCreasedAngle function
Methuselah96 Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions types/three/examples/jsm/utils/BufferGeometryUtils.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,11 @@ export function deinterleaveAttribute(geometry: BufferGeometry): void;
export function deinterleaveGeometry(geometry: BufferGeometry): void;

/**
* Creates a new, non-indexed geometry with smooth normals everywhere except faces that meet at an angle greater than the crease angle.
* Modifies the supplied geometry if it is non-indexed, otherwise creates a new, non-indexed geometry. Returns the
* geometry with smooth normals everywhere except faces that meet at an angle greater than the crease angle.
*
* @param geometry The input geometry.
* @param creaseAngle The crease angle.
* @param creaseAngle The crease angle in radians.
*/
export function toCreasedNormals(geometry: BufferGeometry, creaseAngle?: number): BufferGeometry;

Expand Down