Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "type": "module" #532

Merged
merged 4 commits into from
Jul 5, 2023
Merged

Add "type": "module" #532

merged 4 commits into from
Jul 5, 2023

Conversation

Methuselah96
Copy link
Contributor

@Methuselah96 Methuselah96 commented Jul 5, 2023 •
edited
Loading

Why

three.js specifies "types": "module", so the types should as well.

What

Add "type": "module"

Checklist

  • Checked the target branch (current goes master, next goes dev)
  • Added myself to contributors table
  • Ready to be merged

@Methuselah96 Methuselah96 marked this pull request as ready for review July 5, 2023 22:44
@Methuselah96 Methuselah96 merged commit 952e7cc into master Jul 5, 2023
@Methuselah96 Methuselah96 deleted the esm branch July 5, 2023 22:45
@Methuselah96 Methuselah96 mentioned this pull request Jul 5, 2023
Closed
3 tasks
@OndrejSpanel OndrejSpanel mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Methuselah96