Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSL changes #429

Merged
merged 3 commits into from
Apr 27, 2023
Merged

TSL changes #429

merged 3 commits into from
Apr 27, 2023

Conversation

Methuselah96
Copy link
Contributor

@Methuselah96 Methuselah96 commented Apr 27, 2023

Why

Make type changes corresponding to mrdoob/three.js#25683 and mrdoob/three.js#25685.

What

Many updates.

Checklist

  • Checked the target branch (current goes master, next goes dev)
  • Added myself to contributors table
  • Ready to be merged

@Methuselah96 Methuselah96 mentioned this pull request Apr 27, 2023
37 tasks
@Methuselah96 Methuselah96 changed the title TSL: Different params order if method chaining is used. TSL changes Apr 27, 2023
@Methuselah96 Methuselah96 merged commit bd60c38 into dev Apr 27, 2023
@Methuselah96 Methuselah96 deleted the node-names branch April 27, 2023 14:20
@LeviPesin
Copy link

Do you consider porting mrdoob/three.js#25498? It's a quite a large PR with quite a many breaking changes.

@Methuselah96
Copy link
Contributor Author

It is stated in the README:

It is not a goal for the examples/jsm directory to have complete declaration files for every examples module due to the number of example modules and how quickly they are modified. If you would like to use an examples module that is missing types then create a PR to add the types or create an issue to request that we add the missing types for that module.

Unfortunately I (we) don't have the bandwidth to keep pace with the changes made to the nodes directory. The most we have time for is removing types that are no longer accurate. We would love it if someone was able to contribute those changes though, and would be glad to review and merge them.

@Methuselah96
Copy link
Contributor Author

My priority at the moment is releasing r152 type changes, but I may took a look at that PR (and the nodes types in general) after I'm done with getting r152 released.

@Methuselah96
Copy link
Contributor Author

@LeviPesin FYI, I finally got around to this in #720. Still a few nodes missing, but at least got the ShaderNodeElements refactor out of the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants