Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

three: update AudioContext.d.ts #234

Merged
merged 1 commit into from
Jul 19, 2022
Merged

three: update AudioContext.d.ts #234

merged 1 commit into from
Jul 19, 2022

Conversation

Vikontte
Copy link
Contributor

@Vikontte Vikontte commented Jun 30, 2022 •
edited
Loading

Why

https://github.com/mrdoob/three.js/blob/master/src/audio/AudioContext.js

What

Added argument type in setContext

Checklist

  • Checked the target branch (current goes master, next goes dev)
  • Ready to be merged

yarn contributors:add throws error Unsupported issue: Expected "[", "false", "null", "true", "{", number, or string but "]" found.

@joshuaellis joshuaellis merged commit 6ec4899 into three-types:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaellis joshuaellis joshuaellis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vikontte @joshuaellis